deployment,apollo_deployments: drop config_format plumbing and retire preset config path#14646
Conversation
|
This change is |
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
0df4a4a to
a07b98f
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
39a3bb3 to
e704bbc
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
e704bbc to
b9c5305
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
a07b98f to
a3d7879
Compare
… preset config path
Make native the sole config path in the cdk8s deploy and remove the now-dead
preset machinery:
- Delete the --config_format container arg (pod_builder) and the whole config_format
plumbing (cli.py --config-format flag + threading through app.py, charts/node.py,
constructs/{deployment,statefulset,configmap}). Phase 1 removed --config_format from
the Rust node's parser, so emitting it to the container made the node panic on an
unknown arg; the node now receives only --config_file. Verified by running the node
on a synthesized native ConfigMap (reaches 'Finished loading configuration').
- Retire the python preset path: delete NodeConfigLoader and the $$$ placeholder-fill
machinery (loaders.py); ConfigMap is always built via build_native_config.
- Remove the two preset-parity python tests + their preset-only helpers; keep all native
mirror/deep-merge/port tests.
All hybrid overlays (mainnet, sepolia-alpha, sepolia-integration, testing/node-0,
testing/all-constructs) synth nested native; no synthesized container passes
--config_format; pytest test/ green.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
b9c5305 to
66a55ac
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
a3d7879 to
4dfdb44
Compare
PR SummaryMedium Risk Overview Preset path deleted: Container args fixed: Pods no longer pass Reviewed by Cursor Bugbot for commit 4dfdb44. Bugbot is set up for automated code reviews on this repo. Configure here. |
2 participants
Make native the sole config path in the cdk8s deploy and remove the now-dead
preset machinery:
plumbing (cli.py --config-format flag + threading through app.py, charts/node.py,
constructs/{deployment,statefulset,configmap}). Phase 1 removed --config_format from
the Rust node's parser, so emitting it to the container made the node panic on an
unknown arg; the node now receives only --config_file. Verified by running the node
on a synthesized native ConfigMap (reaches 'Finished loading configuration').
machinery (loaders.py); ConfigMap is always built via build_native_config.
mirror/deep-merge/port tests.
All hybrid overlays (mainnet, sepolia-alpha, sepolia-integration, testing/node-0,
testing/all-constructs) synth nested native; no synthesized container passes
--config_format; pytest test/ green.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com